fix: share one --version probe on activation - #240
Merged
Conversation
Activate starts status bar, auto-update, and native MCP register together. Coalesce concurrent resolvePatchloomStatus() calls so a cold CLI is only exec'd once. No TTL cache, so later settings and install changes still re-probe. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
A long cold --version probe must not pin stale path or trust results when the user changes settings or a managed install finishes. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 01:42
SebTardif
enabled auto-merge (squash)
August 28, 2026 01:42
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activate no longer runs
patchloom --versionthree times. ConcurrentresolvePatchloomStatus()callers share one in-flight probe. Settings, trust, and managed-install refreshes drop that probe first so they do not reuse a stale result.Why
refreshStatusBar(),checkForUpdates(), andregisterMcpServerProviderWithBinary()each resolved status on activate. A cold managed binary paid that cost three times.The change
resolvePatchloomStatusWithSharedInflightcoalesces concurrent probesVerification
npm run check(372 passed, 6 skipped)Closes #239
Checklist
git commit -snpm run checkand it passes