fix: stage symlink patches and honor space-form doc update hints - #247
Merged
Conversation
Zip extract now checks full tar argv. defaultFetchJson stubs assert URL and GitHub headers. generateAgentRules failure logs the raw envelope, not a substring that matches the formatted toast. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Workspace-visible patch symlinks that realpath outside are copied so --contain stays on. Human stderr that says doc update (space form) gets the same picker hint as doc.update. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 13:39
SebTardif
enabled auto-merge (squash)
August 28, 2026 13:39
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cycle 2 after v0.5.0. Tightens tests that would stay green if production
broke, and closes two leftover holes from cycle 1: workspace patch
symlinks that realpath outside were not staged, and human
doc updatestderr did not get the picker hint.
Why
A zip extract test only checked that
xfappeared somewhere in argv.GitHub latest-release stubs ignored URL and headers. Agent-rules failure
logging was asserted with an OR regex that matched the formatted toast.
A workspace-visible symlink to an outside patch skipped the copy step
that keeps
--containon.Verification
npm run check(unit + coverage + package) on this branchdoc updateformatter testChecklist
git commit -snpm run checkand it passes