fix: construct McpStdioServerDefinition positionally and pass env - #250
Merged
Conversation
The VS Code class assigns the first argument to label and does not throw on an options object, so native MCP spawned with no command. Use the positional constructor and forward PATCHLOOM_* env. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 14:52
SebTardif
enabled auto-merge (squash)
August 28, 2026 14:52
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #249. VS Code's
McpStdioServerDefinitionis a positionalconstructor (
label, command, args, env). The first implementationpassed an options object. That does not throw, so
labelbecame theobject and
commandwas undefined. Native MCP never started.Construct positionally and forward filtered
PATCHLOOM_*env frompatchloom.env(includingPATCHLOOM_MCP_SURFACE).Verification
commandis the binary, env is the 4th argumentnpm run checkChecklist
git commit -snpm run checkand it passes