fix: set native MCP server cwd to the workspace folder - #251
Merged
Conversation
VS Code starts McpStdioServerDefinition in $HOME unless cwd is set. Relative MCP paths and --contain then apply to the home directory. Assign workspaceFolders[0].uri after the positional constructor. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 14:59
SebTardif
enabled auto-merge (squash)
August 28, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native MCP still started in
$HOME. VS Code only uses a workspace cwdwhen
McpStdioServerDefinition.cwdis set. Relative MCP tool paths andCLI
--containthen applied to the home directory, not the project.Set
cwdto the first workspace folder URI after constructing thedefinition. The 5th constructor argument is
version, notcwd.Verification
cwd.fsPathon a positional fake ctornpm run checkChecklist
git commit -snpm run checkand it passes