Skip to content

[Feature] Run the Prometheus exposition through a real parser #1631

Description

@pathosDev

Nothing in the repository executes exportPrometheus output against a Prometheus parser. Every claim about the exposition — the #1414 C0-strip decision, the duplicate-row consequence of it, the escaping rules, the grammar the #784 checks enforce — is pinned only by this project's own string assertions.

The C0 decision is the sharpest example. Its evidential base is a reading of two Go parsers that the triage was explicit about: "read, not executed (no Go here)". That caveat did not travel: the conclusion is restated as measured fact in the commit body, the JSDoc, the CHANGELOG and both docs pages.

Proposal. One smoke-style case that runs promtool check metrics (or a vendored parser) over the output of a registry exercising the interesting shapes: an unlabeled family, a histogram, a label value carrying quotes and backslashes, a label value carrying C0 controls, and two tuples that normalise to the same identity. Gate it on the tool being present the way the other capability probes do, so a machine without it skips rather than fails.

That would turn four documented claims from arguments into observations, and it is the one check that would have caught the duplicate-series defect before it shipped rather than three phases later.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestpriority: mediumUseful, not urgentproduction-goalBlocks or defines the path to production readiness

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions