Repository navigation
fix: list only installed patch packs, and add Uninstall all to the Packages panel - #50
Merged
Merged
Conversation
A Debug build reads pack patches from packaging/content/ and also listed every pack the repo carries, so a fresh checkout showed Chorus, Delay and the three reverbs in the drawer with no package installed and none of their plugins present. The repo's sources now shadow installed packs but no longer add packs; PLECTRIFY_LIST_UNINSTALLED_PACKS=1 restores the old listing for authoring a pack before its first publish. Closes #43
patrickiel
changed the title
patrickiel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes: the drawer stops offering patch packs that are not installed (Debug builds), and the Packages panel can uninstall everything at once (all builds).
The drawer lists only installed patch packs
With nothing installed, a Debug build's drawer listed the repo's patch packs (Chorus, Delay, Concert Hall, Room, Plate). Their plugins weren't installed either, so the tiles could be dragged onto the rack but nothing useful loaded.
PlectrifyEngine::handleListFilesused to add everypackaging/content/<id>.<platform>source folder to the shared-root listing. Now it lists only what is installed. For an installed pack, the repo'spatch.jsonstill takes over from the installed one (resolveSharedFileis unchanged), so the edit → restart loop and Update pack source keep working.writablenow names the listed packs that have repo sources.There is no opt-in for listing uninstalled packs: a new pack is installed once before it is edited, which its assets already required.
sharedPatchSourceIdswas only used for the old listing and is removed. AGENTS.md (Installed patches) is updated to match.This part only changes Debug builds, since the repo sources are behind
PLECTRIFY_CONTENT_SOURCE_DIR, which is Debug-only. A Release build already listed only what was installed.Uninstall all, in the Packages panel
The Packages panel gets an Uninstall all button, in every build. It appears in Expert view when at least one package is installed, asks for confirmation inline (
InlineConfirmRow, like the other delete rows), and then uninstalls every installed package in oneuninstallPackagesrun. It is disabled while an install or uninstall is running. It is Expert-only because clearing the machine is a clean-slate errand, not something Simple's list of offers needs.Verification
pnpm app --dist --no-run --no-uion Linux: build OK, CTest 15/15 passed.patch.json;Closes #43