Skip to content

Move packaging and JUCE patch docs out of root AGENTS.md - #51

Merged
patrickiel merged 1 commit into
mainfrom
issue-45-save-as-row-height
Nov 10, 2026
Merged

patrickiel merged 1 commit into
mainfrom
issue-45-save-as-row-height

Conversation

@patrickiel

Copy link
Copy Markdown
Owner

The root AGENTS.md was growing toward the size limit the tooling warns about. Move the two deep dives that only matter inside one folder next to the code they describe, leaving a pointer and the rules that hold everywhere:

  • packaging/AGENTS.md: catalogue tooling reasoning and the procedure for releasing a new version of a source-built plugin. packaging/CLAUDE.md imports it, as at the repo root.
  • cmake/JUCE_PATCHES.md: why each JUCE patch exists, the symptom it fixes, and what a JUCE bump must re-check.

Update the references in packaging/README.md and the NAM state probe comment in CMakeLists.txt to point at the new locations.

Also fix two UI details:

  • SaveAsRow now renders its button and its input in one grid cell, hiding the inactive one, so the row keeps the same height when switching between them (issue Save current as… row changes height when it swaps to the name input #45).
  • Knob no longer draws a dashed ring at rest or rotates it on hover. The ring is now transparent until fine adjust, when it appears as a solid line.

What this changes

Why

How it was tested


  • pnpm app --dist --no-run passes — the same gate the release build uses
    (UI format/check/test, native build, CTest).
  • Ran the app and exercised the change by hand, if it touches audio or UI.
  • UI files formatted with pnpm format in ui/ — not by hand.
  • New code sits in the matching vertical slice, per
    AGENTS.md.
  • A new UI↔engine capability is implemented in both MockEngine and
    JuceEngine, with its handler wired in MainComponent.
  • AGENTS.md updated if this changes architecture, layout or a workflow.

The root AGENTS.md was growing toward the size limit the tooling warns
about. Move the two deep dives that only matter inside one folder next to
the code they describe, leaving a pointer and the rules that hold
everywhere:

- packaging/AGENTS.md: catalogue tooling reasoning and the procedure for
  releasing a new version of a source-built plugin. packaging/CLAUDE.md
  imports it, as at the repo root.
- cmake/JUCE_PATCHES.md: why each JUCE patch exists, the symptom it
  fixes, and what a JUCE bump must re-check.

Update the references in packaging/README.md and the NAM state probe
comment in CMakeLists.txt to point at the new locations.

Also fix two UI details:

- SaveAsRow now renders its button and its input in one grid cell,
  hiding the inactive one, so the row keeps the same height when
  switching between them (issue #45).
- Knob no longer draws a dashed ring at rest or rotates it on hover.
  The ring is now transparent until fine adjust, when it appears as a
  solid line.
@patrickiel
patrickiel merged commit 3b275ff into main Nov 10, 2026
6 of 7 checks passed
@patrickiel
patrickiel deleted the issue-45-save-as-row-height branch November 10, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant