Repository navigation
fix: keep MIDI input pills from running under Refresh - #53
Merged
Merged
Conversation
The device pills in Settings → MIDI were whitespace-nowrap inside a min-w-0 list, so in a narrow sidebar the list shrank below a long name (Linux's "Midi Through Port-0") and the pill spilled out under the Refresh button. A pill is now capped at the list's width and ellipsizes its name, with the full name in a tooltip. Closes #28
Ellipsizing kept the pills off Refresh but cut ordinary names like "Midi Through Port-0" short in the default sidebar width. The Inputs label and Refresh now share a header row and the pills sit on their own line beneath it, so names get the whole strip; one too long even for that wraps inside its pill rather than being clipped. Refs #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Settings → MIDI, a long input name (Linux's always-present "Midi Through Port-0") ran under the Refresh button in a narrow sidebar.
Cause: each device pill was
whitespace-nowrapand sat between the INPUTS label and Refresh, in amin-w-0 flex-1list. The list shrank below the pill's width, and the pill overflowed it.Fix (
MidiSettingsPanel.svelte): the INPUTS label and Refresh now share a header row, and the device pills sit on their own line beneath it, so names get the strip's whole width. A name too long even for that wraps inside its pill (rounded-xl: a full pill on one line, a rounded box on two) instead of being clipped. An earlier version ellipsized the names, but that cut ordinary names short at the default sidebar width.Verified
pnpm format,pnpm check(0 errors) andpnpm test(784 passed) all pass.pnpm dev, with the mock temporarily listing "Midi Through Port-0", "Virtual Foot Controller MIDI 1" and a very long name: at the default sidebar width the first two show in full on one line each, and the long one wraps onto two lines.Closes #28