Repository navigation
fix: keep a TONE3000 capture's name readable on a card with few knobs - #54
Merged
Merged
Conversation
The capture selector took the knob grid's width, so a tone with a single knob left the trigger a sliver beside its two arrows, and a tone with no knobs lost its body - photograph and selector - entirely. The controls column now holds the width of the template's three-column grid whenever there is a selector, and the body renders for a TONE3000 tone whatever its knobs. Captures of one tone share their opening words and differ in the last ones, so the selector now truncates from the start (a new `truncate="start"` on Select) and keeps "(mid gain)" / "(high gain)" visible. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ModuleCard.svelte): the capture selector row is locked to the knob grid's width. With one knob column (4rem), the two step arrows left the trigger about 8px, so no name showed. When a tone has several captures, the controls column now getsmin-w-52(13rem, the width of the template's three-column, six-knob grid). A sparse TONE3000 card is now as wide as a normal one, and its knobs centre inside it.Select.svelte, newtruncate?: 'end' | 'start', defaults to'end'): captures of one tone share their first words and differ at the end, and a trailing ellipsis cut off the only distinguishing part. The capture selector usestruncate="start", so its trigger reads… Channel (mid gain). This uses the rtl ellipsis trick, with a<bdi>so trailing punctuation stays in place. Every other Select is unchanged.Verification
pnpm format,pnpm check(0 errors),pnpm test(784 passed); svelte-autofixer clean on both files.pnpm dev(MockEngine), a TONE3000 module with long capture names:… Channel (mid gain)and both arrows; the menu lists the full names.Closes #6