Repository navigation
fix: prefill bug reports from machines with a large plugin library - #56
Merged
Merged
Conversation
Report a bug dropped the whole diagnostics block once its URL passed the 6000-character cap. On Linux the LSP bundle alone installs ~200 plugins, and their names push the report past the cap, so the form opened with the required Diagnostics field empty. The report now carries shorter stand-ins for the rows that grow with the library (Installed, Skipped), and the bug URL takes the fullest version that fits: plugin names cut to per-vendor counts first, then to totals. The abridged report says itself that the names were left out. Only when no version fits does the old clipboard fallback apply. Closes #35
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
plectrify-site | dc77de0 | Nov 10 2026, 08:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Info → Feedback → Report a bug puts the diagnostics into the GitHub form URL, but drops them completely once that URL is longer than
MAX_ISSUE_URL_LENGTH(6000 chars). On the Linux test machineknown_plugins.xmllists 202 plugins, 198 of them from the LSP bundle. Their names alone take ~6.9 KB once encoded, so every report from that machine overflowed and the form opened with an empty Diagnostics field. This had nothing to do with Linux itself: the Windows machine just has fewer plugins. The native URL hand-off (Process::openDocument→xdg-open) is fine. JUCE escapes every query value before the shell sees it.Change
diagnostics.ts:DiagRowgets an optionalshorterlist of stand-in values. Only the two rows that grow with the library have them:LSP VST3: 198 · Plectrify: 2 · 1 with no vendor), then a single total.Both say
(names left out to fit the issue form).abridgedDiagnostics(report)returns the report at each level, full version first.issueReport.ts:buildBugReportUrlaccepts the versions in order and uses the first one that fits. It reportsabridged, and still reportsoverflowedwhen none fit.InfoPanel.svelte: passes in the abridged versions. The clipboard fallback now only applies when even the shortest version does not fit.The Copy button and the on-screen report are unchanged and always show the full list.
Verification
pnpm format,pnpm check(0 errors) andpnpm test(792 passed) inui/. The new tests include an end-to-end case with a library shaped like the LSP one: the full report overflows, the abridged one prefills.svelte-autofixeronInfoPanel.svelte: no issues.Closes #35