feat: clearer feedback across the identification/save flow - #29
Open
gwado wants to merge 1 commit into
Open
Conversation
Three related UX improvements to the identify -> results -> save flow: - RequestPage now stays visible with its own loading indicator while an identification request is in flight, instead of popping back to MainPage immediately and showing a generic spinner there with no visible connection to what triggered it. On success it pops itself and pushes ResultsPage directly; on error it stays put so the user can retry without re-adding all their photos. - Identification::identifyPlant() now classifies failures instead of always reporting a raw "(err/code)" pair: invalid/rejected API key (401/403), quota exceeded (429), server error (5xx), unreachable network, or a generic fallback, each with a clear message. The identificationResult signal gained an errorCode alongside the existing message so QML can react differently per case - in particular, an invalid-key error now offers to open Settings directly from the error dialog, instead of only surfacing this after the user has already taken photos and started a request. - Saving a result now shows a brief "Plant saved" toast before returning to the saved-plants list, instead of popping back to MainPage with no visible confirmation that the save succeeded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related UX improvements to the identify → results → save flow:
RequestPagenow stays visible with its own loading indicator while an identification request is in flight, instead of popping back toMainPageimmediately and showing a generic spinner there with no visible connection to what triggered it. On success it pops itself and pushesResultsPagedirectly; on error it stays put so the user can retry without re-adding all their photos.Identification::identifyPlant()now classifies failures instead of always reporting a raw "(err/code)" pair: invalid/rejected API key (401/403), quota exceeded (429), server error (5xx), unreachable network, or a generic fallback, each with a clear message. TheidentificationResultsignal gained anerrorCodealongside the existing message so QML can react differently per case — in particular, an invalid-key error now offers to open Settings directly from the error dialog, instead of only surfacing this after the user has already taken photos and started a request.MainPagewith no visible confirmation that the save succeeded.Type of change
New feature
Test plan
clickable build --arch arm64builds cleanly; the produced package passesclickable's click-review.Notes
po/in a way that needs an update for this PR — the new "Plant saved" string and the four new error messages are not yet inpo/plants.s710.pot; happy to run the translation template update if you'd like it included here.