chore(form): update radius on menu toggle#12542
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe FormState example was updated to add the ChangesForm example update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12542.surge.sh A11y report: https://pf-react-pr-12542-a11y.surge.sh |
There was a problem hiding this comment.
Was confused that in https://pf-react-pr-12542.surge.sh/components/forms/form#form-state I couldn't see a difference compared to https://www.patternfly.org/components/forms/form/#form-state.
It turns out that if .pf-v6-theme-felt is applied to the main HTML, the menu toggle was filled. The Felt theme doesn’t seem to be working. It adds a .pf-v6-theme-redhat instead. Once the right class is on both, I see the difference.
We should take a look separately to see why the wrong class name is being applied in Surge/staging.
Related to this issue https://redhat.atlassian.net/browse/PF-4351
There is a single menu toggle in one of the examples that shoouldn't be pilled.
A core PR is also in review to fix the same issue in the HTML example.
Summary by CodeRabbit