Landing page UX and layout refinement (#146) - #148
Open
aizuanjeme wants to merge 1 commit into
Open
Conversation
- Refactored the Testimonials component to use a predefined array of testimonial items, improving maintainability and readability. - Introduced new SVG doodles (CircleScribble, Sparkle, SmileyDoodle) to enhance visual appeal in the testimonials section. - Updated the styling of testimonials for better responsiveness and aesthetics, including hover effects and improved layout. - Added a new Footer component with a custom Payjoin wordmark for branding consistency. - Adjusted custom CSS for footer styling and mobile menu behavior to enhance user experience.
Author
|
Hey @DanGould , just following up on this PR whenever you get a chance. Would appreciate a review when you have some time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #146.
Refines the landing page's layout and UX. Previously each section had its own
type scale, container width, and spacing — the page read as five unrelated
blocks. Everything now shares one design language: a common heading scale, one
container width and gutter, full-bleed colour bands, and consistent card
treatment.
Content is unchanged apart from one deviation, noted at the bottom.
Hero
2rem→6xl) replacing fixed sizingbenefits radiating from it
Why Payjoin
Testimonials
so names line up across the row
pauseOnHoveron the marquee — these cards hold long text meant to be read24remwide, wider than a 375px viewport, so nowhole card was ever visible. Now viewport-relative below
sm.screen. Now proportional.
Prototype demo
3/4on phones,16/10on desktop) instead of66vh,which changed shape with every viewport height
loading="lazy"— it's a heavy third-party embed below the foldallowfullscreen→allowFullScreen, which is not a valid React DOMprop and was being dropped with a console warning
Closing CTA
min-h-screen, which produced a mostly-empty viewport-tall block<h1>s became a single<h2>— the hero already owns the page'sh1, so this also fixes the heading hierarchyFooter
textLength+lengthAdjust="spacing", so the letters span the full widthexactly at any viewport by opening the gaps between them — a
vw-sizedheading can only approximate that and overshoots into a horizontal scrollbar.
@theme-original/Footer), not an eject, sofooter links and copyright stay config-driven in
docusaurus.config.tsandDocusaurus upgrades won't conflict
Page shell
max-sm:gap-20, which showed the page background as a bright stripebetween every section on mobile now that sections paint their own bands
Colours
All from the existing palette (
#f75394/#46192b/#6A394C). No new hues.Sections are assigned different existing shades so the page has depth and
adjacent sections don't merge into each other.
Accessibility and motion
aria-hiddenandpointer-events-noneprefers-reduced-motionOne copy deviation from #146
In the closing section, "Join our newsletter and the Discord to stay up to date
with Payjoin development" became two CTA buttons plus a caption. Same links,
same destinations — keeping the sentence and adding buttons would have meant
four links to two places. Happy to revert if you'd rather the copy stay
untouched.
Notes
yarn.lockdeliberately excluded — no dependency changesCannot find namespace 'JSX'errors fromyarn typecheckare untouched by this PR