Affix rust nightly version weekly instead of latest - #1825
Merged
Conversation
benalleng
marked this pull request as draft
August 19, 2026 18:14
Collaborator
Coverage Report for CI Build 32500599371Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
marked this pull request as ready for review
August 19, 2026 18:19
benalleng
changed the title
benalleng
force-pushed
the
weekly-nightly-bump
branch
from
August 19, 2026 18:21
a1fddba to
9203160
Compare
caarloshenriq
approved these changes
Aug 20, 2026
spacebear21
requested changes
Aug 21, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
cACK, the second commit looks overly complicated I wonder if we can simplify somehow.
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Install Nix | ||
| uses: DeterminateSystems/nix-installer-action@main |
Collaborator
There was a problem hiding this comment.
Should this use the shared setup-nix action?
| @@ -12,21 +12,24 @@ jobs: | |||
| - 1.85.0 # MSRV | |||
| - stable | |||
| - nightly | |||
Collaborator
There was a problem hiding this comment.
Maybe an easier solution would be to always update this line with the bump-nightly.sh script? We could have NIGHTLY_VERSION as an env variable for the workflow so it only needs to be updated in once place.
benalleng
force-pushed
the
weekly-nightly-bump
branch
from
August 21, 2026 15:59
9203160 to
92d286b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup on #1131 and the chain of related PRs. One thing I noticed was the restore keys were always grabbing new rust nightly versions so this attempts to at least affix the master version on a weekly basis if there is nothing merged in. While this will not solve the immediate churn it think it can help prevent the master branch from being dropped every day.
Coded up with help from GLM-5.3
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.