Skip to content

Foundry tests never run in CI and aren't required to merge #31

Description

@kirilly

The test workflow (forge build + forge test) is set to on: workflow_dispatch, so it only runs when someone triggers it by hand. It has 0 runs in the Actions history. Nothing runs it on pull requests or pushes.

On top of that, none of the branch rulesets require a status check (checks=[] on all of them), so even a manual failing run wouldn't block a merge. The only automated CI on the repo is CodeQL default setup. For a smart-contract repo, that means changes can land on main with no build or test having run.

Suggested fix

Add pull_request (and probably push to main/dev) triggers to test.yml, then add a ruleset that requires the resulting check on main/dev. Same shape peanut-ui uses with ci-success.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions