Skip to content

tests.yml: Add PHP 8.5 - #31

Merged
alecpl merged 1 commit into
pear:masterfrom
reedy:patch-2
Jan 25, 2026
Merged

alecpl merged 1 commit into
pear:masterfrom
reedy:patch-2

Conversation

@reedy

@reedy reedy commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@alecpl

alecpl commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Thanks. Looks like all tests fail because of PHP Deprecated: PHP Startup: Directive 'report_memleaks' is deprecated in Unknown on line 0.

@alecpl

alecpl commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Try this:

--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -25,6 +25,7 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
           coverage: none
+          ini-values: display_startup_errors=off
 
       - name: Execute tests
         run: pear run-tests tests/*.phpt

@alecpl

alecpl commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

I see you're already on it pear/pear-core#161

@ashnazg

ashnazg commented Jan 25, 2026

Copy link
Copy Markdown
Member

I see you're already on it pear/pear-core#161

@alecpl , fixed in pear-core v1.10.18.

@alecpl
alecpl merged commit deabd55 into pear:master Jan 25, 2026
6 of 12 checks passed
@alecpl

alecpl commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Ouch. I merged it, but we need a new release of pear/pear-core-minimal to work.

@reedy
reedy deleted the patch-2 branch January 25, 2026 18:34
@ashnazg

ashnazg commented Jan 25, 2026

Copy link
Copy Markdown
Member

Ouch. I merged it, but we need a new release of pear/pear-core-minimal to work.

Didn't realize anyone was explicitly tying minimal release #s to core release #s for workflows... I've updated my release steps to always do an accompanying minimal tag going forward... I've now created minimal tags for .17 and .18.

@reedy

reedy commented Jan 25, 2026

Copy link
Copy Markdown
Contributor Author

Guess it would be worth re-running tests to confirm they're passing and there's no other issues wrt PHP 8.5

@alecpl

alecpl commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Damn. It seems we're not using composer in CI. I tried my display_startup_errors=off change from the comment above, it does not seem to help. So, I guess we need either make tests use composer dependencies or update Pear in the system somehow.

@alecpl

alecpl commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Solved. Tests pass in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants