[BUGFIX] Timeserieschart: default query color mode to fixed for all series#753
Open
mixturesolutions wants to merge 2 commits into
Open
[BUGFIX] Timeserieschart: default query color mode to fixed for all series#753mixturesolutions wants to merge 2 commits into
mixturesolutions wants to merge 2 commits into
Conversation
When adding a query color setting, default to "fixed" so the color applies to every series returned by the query, matching other query settings and the expected behavior from perses/perses#4204. Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes perses/perses#4204.
When adding a query color setting, the UI defaulted to
fixed-single, which only applies the color if the query returns one series. Other query settings (line style, opacity, etc.) always apply to every series from that query, so multi-series queries looked inconsistent: dash/dot applied, but color did not.This changes the default color mode to
fixed, so the configured color applies to all series returned by the query. Users can still select Fixed (single series) when they want the previous behavior.Screenshots
Before the chart defaults to:
After the pr, chart defaults to:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes