Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffenv.Parsereturns nil after its scanner stops, even when it stopped on a read error or an overlong line. A partially read.envfile can therefore be accepted as successful configuration.Return
s.Err(), asff.PlainParseralready does. Clean EOF still succeeds; a read failure is returned to the caller instead of being discarded.Added four cases: a reader failing immediately, a reader failing after a valid setting, a line exceeding the scanner limit, and clean EOF without a trailing newline. The first three fail on the base; all four pass with this change.
Validation on Go 1.26.7 / macOS arm64:
go test -race ./...,go vet ./..., and staticcheck pass.git diff --checkpass.No dependencies or scanner size limits change. Settings processed before a reader failure remain applied; this change reports that failure rather than adding rollback.
AI assistance: implemented and tested with OpenAI Codex; no human review before submission.