Skip to content

Add optional Helm DNS and workload settings - #283

Open
dihmandrake wants to merge 1 commit into
pgsty:mainfrom
dihmandrake:helm-native-tls-values
Open

dihmandrake wants to merge 1 commit into
pgsty:mainfrom
dihmandrake:helm-native-tls-values

Conversation

@dihmandrake

Copy link
Copy Markdown

Contribution Licensing (no CLA, inbound=outbound, DCO required)

This pull request contributes to PGSTY SILO (pgsty/silo). Code contributions
are accepted under AGPL-3.0-or-later, the same license as the server.
This project does not use a CLA or require a separate Apache-2.0 license grant.
By submitting this pull request I represent that I have the right to contribute
the code changes under this repository's
GNU Affero General Public License v3.0 or later
and retain copyright in my original work. Existing copyright and license
notices remain intact; separately licensed material keeps its applicable terms.
Every commit must carry a DCO Signed-off-by trailer
(git commit -s) certifying the
Developer Certificate of Origin — see
CONTRIBUTING.md.

Description

TL;DR: Add optional Helm values for full internal DNS names, Kubernetes probes, shutdown grace, Console Service creation, and provisioning Job cleanup.

Full DNS names use the existing clusterDomain value for distributed peers and provisioning, with matching TLS server names for metrics. The other options render standard Kubernetes fields. Existing defaults and resource identities are preserved.

This change was written with AI assistance. Validation covers chart rendering and a local integration comparison; it has not been deployed as an upstream chart release. The contributor has limited familiarity with Silo internals.

Motivation and Context

Using native TLS with certificates covering full Kubernetes DNS names currently requires overriding the generated peer command and provisioning endpoints. Health checks, shutdown grace, Job TTL, and disabling an unused Console Service also require downstream patches. These opt-in values let installations configure those behaviors without duplicating generated resources.

How to test this PR?

Run buildscripts/verify-helm-migration.sh and make rebrand-guard; both passed against the current upstream base.

Local render checks also passed for standalone/distributed modes, HTTP/HTTPS, default/custom cluster domains, multiple pools and drives, explicit zero values, three probe types, and the invalid Console Service/ingress combination. Default rendered resources were identical to the base chart. Replacing four downstream patches with values produced identical output for all 31 integration resources; schema validation passed for 28 resources with 3 custom resources skipped.

The additional render harness is retained locally as review evidence, outside this chart-only patch. No server code changed; the full server verifier/build suite was not rerun.

Compatibility impact

All new settings are optional. Short DNS names, absent probes, the default shutdown grace, Console Service creation, and existing Job retention remain the defaults. Names, selectors, PVCs, drive ordering, API paths, and MINIO_* interfaces are unchanged. Provisioning scripts retain their existing TLS-verification behavior.

Enabling useFQDN changes peer endpoint names and requires matching certificates and coordinated peer restarts. Coordinate the reverse change if rolling back. The chart README describes the values and this upgrade consideration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • All commits are signed off (git commit -s) per the DCO
  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • make verifiers passes
  • Relevant package tests and make build pass
  • Compatibility and rollback impact documented
  • Internal documentation updated
  • Public documentation update opened in pgsty/silo.pgsty.com, if needed

Allow fully qualified peer and provisioning hostnames using clusterDomain,
with matching TLS server names for metrics. Expose Kubernetes probe specs,
shutdown grace, Console Service enablement, and provisioning Job TTL.

Preserve existing defaults and resource identities so deployments can
replace common overrides without changing runtime behavior.

Signed-off-by: Jasper Bernhardt <jasper.bernhardt@gmail.com>
@dihmandrake
dihmandrake force-pushed the helm-native-tls-values branch from 7f3c3c6 to 70503a0 Compare November 15, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant