Repository navigation
Add optional Helm DNS and workload settings - #283
Open
dihmandrake wants to merge 1 commit into
Open
dihmandrake wants to merge 1 commit into
dihmandrake wants to merge 1 commit into
Conversation
Allow fully qualified peer and provisioning hostnames using clusterDomain, with matching TLS server names for metrics. Expose Kubernetes probe specs, shutdown grace, Console Service enablement, and provisioning Job TTL. Preserve existing defaults and resource identities so deployments can replace common overrides without changing runtime behavior. Signed-off-by: Jasper Bernhardt <jasper.bernhardt@gmail.com>
dihmandrake
force-pushed
the
helm-native-tls-values
branch
from
November 15, 2026 14:30
7f3c3c6 to
70503a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Licensing (no CLA, inbound=outbound, DCO required)
This pull request contributes to PGSTY SILO (
pgsty/silo). Code contributionsare accepted under AGPL-3.0-or-later, the same license as the server.
This project does not use a CLA or require a separate Apache-2.0 license grant.
By submitting this pull request I represent that I have the right to contribute
the code changes under this repository's
GNU Affero General Public License v3.0 or later
and retain copyright in my original work. Existing copyright and license
notices remain intact; separately licensed material keeps its applicable terms.
Every commit must carry a DCO
Signed-off-bytrailer(
git commit -s) certifying theDeveloper Certificate of Origin — see
CONTRIBUTING.md.
Description
TL;DR: Add optional Helm values for full internal DNS names, Kubernetes probes, shutdown grace, Console Service creation, and provisioning Job cleanup.
Full DNS names use the existing clusterDomain value for distributed peers and provisioning, with matching TLS server names for metrics. The other options render standard Kubernetes fields. Existing defaults and resource identities are preserved.
This change was written with AI assistance. Validation covers chart rendering and a local integration comparison; it has not been deployed as an upstream chart release. The contributor has limited familiarity with Silo internals.
Motivation and Context
Using native TLS with certificates covering full Kubernetes DNS names currently requires overriding the generated peer command and provisioning endpoints. Health checks, shutdown grace, Job TTL, and disabling an unused Console Service also require downstream patches. These opt-in values let installations configure those behaviors without duplicating generated resources.
How to test this PR?
Run buildscripts/verify-helm-migration.sh and make rebrand-guard; both passed against the current upstream base.
Local render checks also passed for standalone/distributed modes, HTTP/HTTPS, default/custom cluster domains, multiple pools and drives, explicit zero values, three probe types, and the invalid Console Service/ingress combination. Default rendered resources were identical to the base chart. Replacing four downstream patches with values produced identical output for all 31 integration resources; schema validation passed for 28 resources with 3 custom resources skipped.
The additional render harness is retained locally as review evidence, outside this chart-only patch. No server code changed; the full server verifier/build suite was not rerun.
Compatibility impact
All new settings are optional. Short DNS names, absent probes, the default shutdown grace, Console Service creation, and existing Job retention remain the defaults. Names, selectors, PVCs, drive ordering, API paths, and MINIO_* interfaces are unchanged. Provisioning scripts retain their existing TLS-verification behavior.
Enabling useFQDN changes peer endpoint names and requires matching certificates and coordinated peer restarts. Coordinate the reverse change if rolling back. The chart README describes the values and this upgrade consideration.
Types of changes
Checklist:
git commit -s) per the DCOcommit-idorPR #here)make verifierspassesmake buildpasspgsty/silo.pgsty.com, if needed