ci: pin release workflow actions to commit SHAs (FEPLAT-5069) - #42
Draft
casper-phantom[bot] wants to merge 1 commit into
Draft
ci: pin release workflow actions to commit SHAs (FEPLAT-5069)#42casper-phantom[bot] wants to merge 1 commit into
casper-phantom[bot] wants to merge 1 commit into
Conversation
Mutable refs (actions/checkout@v3, actions/setup-node@v3, changesets/action@v1) let a moved tag or compromised upstream change CI code that publishes to npm without a change in this repo. Pin each to the 40-character commit its current ref resolves to, with the version in a trailing comment. No version change: the pinned SHAs are exactly what the mutable refs resolve to today. Co-authored-by: casper-phantom[bot] <208212958+casper-phantom[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now pins the checkout, Node.js setup, and Changesets actions to specific commit SHAs instead of mutable version tags. ChangesRelease workflow
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FEPLAT-5069
Note
Low risk: The pinned SHAs are exactly what the mutable refs resolve to now, so the release job runs identical action code; the only behavior change is that upstream updates no longer arrive silently.
Summary
Pinned refs
actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26(v3.7.0)actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610(v3.9.1)changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d(v1.9.0, previously thev1branch head)Each SHA was resolved from the upstream repository's ref API at the ref the workflow used, and each
action.ymlwas checked for nesteduses:entries (none).Follow-up worth tracking separately
actions/checkoutandactions/setup-nodeare on the v3 line, which declaresusing: node16; both upstreams are now on v7. Pinning does not make that worse, but a version bump should be its own change so a behavior regression in the release job is not tangled with the security pin.casper-run-id: 019fd2d6-e983-78c6-b3fc-6f0de9cb446c
Summary by CodeRabbit