Repository navigation
ENTSOG PartyId type is entsoe.eu, not entsog.eu - #403
Merged
Merged
Conversation
The ENTSOG AS4 Usage Profile fixes the PartyId type attribute to http://www.entsoe.eu/eic-codes/eic-party-codes-x (the EIC scheme is maintained by ENTSO-E). The constant had entsog.eu. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ENTSOGPMode.ENTSOG_PARTY_ID_TYPE(also used byENTSOG4PMode) ishttp://www.entsog.eu/eic-codes/eic-party-codes-x. The ENTSOG AS4 Usage Profile requires the hostentsoe.eu, because the EIC scheme is maintained by ENTSO-E:That sentence, and the example messages, read the same in Rev 3.6 (
docs/ENTSOG/INT0488-161115 AS4 Usage Profile_Rev_3.6_clean_final.pdf, "Party Identification" and section 3.1) and in the 4.0 public review draft indocs/ENTSOG/. A counterparty that follows the profile (the Danish gas DSO's AS4 endpoint in our case) sends and expectsentsoe.eu, so the default PMode of the ENTSOG profile does not match it.Change
http://www.entsoe.eu/eic-codes/eic-party-codes-x, with a Javadoc note about entsoe vs entsog.ENTSOGPModeTestasserts the PartyId type of initiator and responder.mvn -pl phase4-profile-entsog,phase4-entsog-client test: 29 + 3 tests, 0 failures.Compatibility
This changes the PartyId
typethat the default ENTSOG PMode puts on the wire. Anyone who relied on the old value between two phase4 instances would need both sides on the same version; against a profile-conformant partner the old value was already wrong. If you would rather keep the old constant for a deprecation cycle and add a new one, I can rework it that way.A related question (not changed here)
The ENTSOG PMode template uses
CAS4.DEFAULT_ACTION_URL(.../ebms/v3.0/ns/core/200704/test) as its action. Section 2.3.1.2.2 of the profile reserves that URI for the pre-defined test service and useshttp://docs.oasis-open.org/ebxml-msg/as4/200902/action(the AS4 default action) for business messages when no specific action is listed. Would you take a PR that adds that URI as a constant and uses it as the ENTSOG default, or is the generic default intentional across profiles?🤖 Generated with Claude Code