fix: clicks no longer silently deleted when adjacent to a modifier - #387
Open
varunghat wants to merge 2 commits into
Open
fix: clicks no longer silently deleted when adjacent to a modifier#387varunghat wants to merge 2 commits into
varunghat wants to merge 2 commits into
Conversation
drammock
requested changes
Aug 4, 2026
| codepts[codepts %in% get_codepoints(base_glyphs)] <- "B" | ||
| codepts[codepts %in% get_codepoints(modifiers)] <- "M" | ||
| codepts[codepts %in% get_codepoints(clicks)] <- "M" | ||
| codepts[codepts %in% get_codepoints(clicks)] <- "K" |
Member
There was a problem hiding this comment.
I checked git blame for this line, which led me to #365. It's PR description says (among other things):
when building feature vectors, clicks are now handled like modifiers (not like base glyphs), which makes it easier to get the correct features (previously they were incorrect)
SO I think this change will likely result in incorrect feature vectors for clicks. I'd rather try changing the line in order_ipa that checks for modifiers %in% mods (see other comment)
| for (row in seq_len(dim(ixs)[1])) { | ||
| span <- ixs[row,1]:ixs[row,2] | ||
| mods <- string[span] | ||
| string[span] <- modifiers[modifiers %in% mods] |
Member
There was a problem hiding this comment.
I think this is the correct fix
Suggested change
| string[span] <- c(clicks, modifiers)[c(clicks, modifiers) %in% mods] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes clicks getting silently deleted when reordering an adjacent modifier
(e.g. kǀʰʷ -> kʷʰʷ) in order_ipa()
Clicks were typed the same as modifiers ("M") in make_typestring()
Gave clicks their own typestring code ("K").
Doesn't touch feature-helper-functions.R's separate click="M" typing, so feature computation is unaffected.