Allow PHPUnit 12 and 13 - #19
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 94.14% 94.14%
Complexity 104 104
=========================================
Files 1 1
Lines 239 239
=========================================
Hits 225 225
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified in the reviewed changes.
Pull request overview
This pull request expands PHPUnit support through version 13, updates test metadata and CI coverage, and removes obsolete APC configuration.
Changes:
- Migrates data providers to PHPUnit attributes.
- Allows PHPUnit versions 10–13.
- Updates PHP CI coverage for 8.1, 8.3, and 8.5.
- Removes the obsolete APC setting.
File summaries
| File | Summary |
|---|---|
tests/DecimalTest.php |
Migrates data providers to attributes. |
phpunit.xml.dist |
Removes obsolete APC configuration. |
composer.json |
Allows PHPUnit 12 and 13. |
.github/workflows/ci.yml |
Updates the PHP CI matrix. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
composer validate --strictcomposer stancomposer cs-checkReview note
The required local Claude CLI review was attempted, but the CLI reported that its session limit had been reached.