ci: drop the phiki capture-offset patch, which phiki 2.2.1 made obsolete - #60
Open
dereuromark wants to merge 1 commit into
Open
dereuromark wants to merge 1 commit into
dereuromark wants to merge 1 commit into
Conversation
Every CI job on this repository fails at `composer install`, and has since
phiki released 2.2.1:
patch-phiki-offsets: anchor not found - phiki changed, re-check the
upstream fix.
Script php scripts/patch-phiki-offsets.php handling the post-update-cmd
event returned with error code 1
The script patched a v2.2.0 bug in phiki's capture-offset recovery, and its own
header said to remove it when the upstream fix shipped. It has: the anchor is
missing precisely because that code changed. There is no composer.lock here, so
every install resolves the latest phiki and every install has been failing.
The failure is not a false alarm to be silenced - it is the script correctly
refusing to patch code it no longer recognizes. What it needed was acting on.
sibling precedent: wp-carve carried the identical patch, removed it on the same
reasoning, and has been running phiki v2.2.1 unpatched since.
Removed from the composer hooks, from scripts/build.sh - where a comment noted
the hooks do not fire under --working-dir - and the script itself. Verified:
composer install completes and resolves phiki v2.2.1; phpunit, phpstan and
phpcs all run and pass, none of which could execute before.
dereuromark
force-pushed
the
drop-phiki-patch
branch
from
August 27, 2026 23:27
392558c to
f58bd6f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix CI by removing the now-obsolete phiki capture-offset patch script that was previously applied during installs/builds.
Changes:
- Deletes
scripts/patch-phiki-offsets.php(previously used to patchphiki/phikiv2.2.0). - (Intended per PR description, but not present in the provided diffs) Remove references to that script from Composer hooks and the dist build script.
Suppressed comments (1)
scripts/patch-phiki-offsets.php:1
- This PR deletes
scripts/patch-phiki-offsets.php, butcomposer.jsonandscripts/build.shstill invoke it (e.g.post-install-cmd/post-update-cmdand an explicit call inbuild.sh). As-is,composer installwill fail with “Could not open input file scripts/patch-phiki-offsets.php” (and dist builds will fail too). Either keep the script, or update those call sites to remove/empty the hooks and delete the build-step invocation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
26
to
28
| echo "Installing production dependencies..." | ||
| cp "$PLUGIN_DIR/composer.json" "$PLUGIN_DIR/composer.lock" "$TMP_DIR/" | ||
| php "$(command -v composer)" install --working-dir="$TMP_DIR" --no-dev --optimize-autoloader --no-interaction --no-scripts --quiet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every CI job on this repository fails at
composer install, and has since phiki released 2.2.1:Six jobs, all dying before they compile anything - PHPStan, both syntax checks, both test matrices, Plugin Check and WP Integration.
scripts/patch-phiki-offsets.phppatched a v2.2.0 bug in phiki's capture-offset recovery, and its own header said:It has shipped. The anchor is missing precisely because that code changed upstream. There is no
composer.lockhere, so every install resolves the latest phiki - which means every install has been failing rather than only new ones.The failure was never a false alarm to silence: the script correctly refused to patch code it no longer recognized. It needed acting on.
Sibling precedent. wp-carve carried the identical patch, removed it on the same reasoning, and has been running phiki
v2.2.1unpatched since - its changelog records the removal explicitly.Removed from three places: the
post-install-cmd/post-update-cmdhooks,scripts/build.sh(where a comment noted the hooks do not fire under--working-dir, so it invoked the script directly), and the script itself.Verified locally:
composer installcompletes and resolves phikiv2.2.1, and phpunit, phpstan and phpcs all run and pass - none of which could execute before this.