Skip to content

Fix record: mago analyze flags loadConstraintDataNames() as unused-method in Metadata/Source.php #63

Closed

Description

@tyrsson

Context

Part of #60.

Data

mago analyze flags help[unused-method] on Metadata\Source::loadConstraintDataNames(). It writes to $this->data['constraint_names'][$schema], but no other method in Source.php, AbstractSource, or MetadataInterface reads that key or exposes it via a public getter (unlike its sibling loadConstraintDataKeys(), which backs AbstractSource::getConstraintKeys()).

@simon-mundy has the most context on this part of the SQL/metadata handling and knows the scope of the refactor needed here better than we do.

This finding will be captured in a mago baseline rather than fixed or suppressed inline.

Activity

  1. added this to the 0.5.0 milestone on Aug 10, 2026
  2. added theissue type on Aug 10, 2026
  3. tyrsson commented on Oct 7, 2026

    @tyrsson
    MemberAuthor

    Closing as resolved. loadConstraintDataNames() is captured as unused-method in the committed analysis-baseline.toml for src/Metadata/Source.php, per the disposition recorded in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions