Repository navigation
Fix record: mixed-* findings in Metadata/Source.php stem from untyped upstream AbstractSource::$data #64
Description
Context
Part of #60.
Data
mago analyze flags mixed-array-assignment, possibly-invalid-argument, reference-constraint-violation, and too-many-arguments throughout src/Metadata/Source.php wherever $this->data is read or written. Root cause is upstream: AbstractSource::$data (php-db/phpdb) is declared protected array $data = []; with no shape, so every keyed access resolves to mixed. Tracked upstream at php-db/phpdb#168.
@simon-mundy has the most context on this part of the SQL/metadata handling.
These findings will be captured in a mago baseline rather than fixed or suppressed inline.
Activity
mago analyze: generate baseline for remaining tracked findings
tyrsson commentedon Oct 7, 2026
Closing as resolved. The
mixed-*findings insrc/Metadata/Source.phpstemming from the untyped upstreamAbstractSource::\are captured in the committedanalysis-baseline.toml(20 entries), pending the upstream fix at php-db/phpdb#168.