Repository navigation
Walk DDL column lists with foreach - #216
Merged
simon-mundy merged 5 commits intoOct 6, 2026
Merged
Conversation
AbstractSql::processJoin() and Select read an aliased table's alias with array_key_first() instead of key()/current(), so the result no longer depends on the array's internal pointer and the analyzer can see the alias is a string. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
AbstractConstraint and Index iterate their column lists with foreach instead of indexing from zero, which the analyzer cannot prove is in range. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
simon-mundy
added
documentation
Cover multi-column primary and unique keys, which a single column could not distinguish from leaving the column specification unexpanded. Ignore the array_fill() start-index mutants in getExpressionData(), as already done for ForeignKey: implode() discards the keys, so the start index cannot be observed. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
marked this pull request as ready for review
October 6, 2026 02:18
tyrsson
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #215. Until the earlier PRs in this series merge, this diff also shows their commits; the change here is the last commit, "Walk DDL column lists with foreach".
Removes 4 analyzer findings (
possibly-null-argument,possibly-undefined-int-array-index) insrc/Sql/Ddl.Changes
AbstractConstraint::getExpressionData()andIndex::getExpressionData()iterate their column lists withforeachinstead of indexing from zero, which the analyzer cannot prove is in range.src/Sqlentries change.Breaking changes
None.
mago format,mago lint,mago analyzeand the unit tests pass.