Repository navigation
Cast scalar values to string before quoting them - #222
Merged
simon-mundy merged 5 commits intoOct 9, 2026
Merged
Conversation
PlatformInterface::quoteValue() takes a string, so an integer limit, offset or column value raised a TypeError under strict types once a platform with a driver tried to quote it. The test platform now keeps the string type, so the suite catches the same mistake again. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…lue-scalars # Conflicts: # analyzer-baseline.toml
tyrsson
previously approved these changes
Oct 8, 2026
…e-scalars # Conflicts: # analyzer-baseline.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205.
Integer and boolean values reached
PlatformInterface::quoteValue(string)from strict-typed call sites, raising aTypeErroron any platform that keeps thestringtype.Changes
Select::processLimit()andprocessOffset()cast the limit and offset to string before quoting.AbstractSql::resolveColumnValue()casts the column value to string before quoting, as the expression path already does.TrustingSql92Platform::quoteValue()keeps thestringparameter type, so the suite fails if a call site passes a non-string again. With only this change, 6 existing tests error.Breaking changes
None. Prepared statements are unaffected; they bind values rather than quoting them.
mago format,mago lint,mago analyzeand the unit tests pass.