Repository navigation
Throw InvalidArgumentException for join names without a leading string - #223
Merged
Merged
Conversation
An invalid join name array whose first element was not a string, such as an empty array or an unaliased Select, reached forInvalidJoinName() with a non-string and raised a TypeError. The message now names the element's type instead. Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…e-type # Conflicts: # analyzer-baseline.toml
tyrsson
previously approved these changes
Oct 8, 2026
Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206.
Join::join()built its invalid-name exception from the name array's first element. When that element was not a string,forInvalidJoinName(string)raised aTypeErrorinstead.Changes
get_debug_type()), e.g.join() expects 'int' as a single element associative array. A string element is reported as before.JoinTestcovers an empty array, an unaliasedSelectand an integer element.Breaking changes
None.
mago format,mago lint,mago analyzeand the unit tests pass.