Repository navigation
Describe any kind of table in Sql's foreign-table exception - #226
Merged
simon-mundy merged 5 commits intoOct 9, 2026
Merged
Conversation
Sql::delete(), insert(), select() and update() passed their table to forForeignTable(string), which raised a TypeError when the table was a TableIdentifier or an aliased array. forForeignTable() now accepts all three and describes a TableIdentifier as schema.table and an aliased array as "table AS alias". Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…table-message # Conflicts: # analyzer-baseline.toml
tyrsson
previously approved these changes
Oct 8, 2026
…ble-message # Conflicts: # analyzer-baseline.toml # test/unit/Sql/SqlTest.php Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210.
Sql::delete(),insert(),select()andupdate()passed their table toforForeignTable(string), which raised aTypeErrorwhen the table was aTableIdentifieror an aliased array.Changes
Sql\Exception\InvalidArgumentException::forForeignTable()acceptsstring|TableIdentifier|array. It describes aTableIdentifierasschema.table(ortablewithout a schema), and an aliased array astable AS alias.InvalidArgumentExceptionTestandSqlTestcover each kind of table.Breaking changes
None. The parameter type is widened.
mago format,mago lint,mago analyzeand the unit tests pass.