Skip to content

Bring Sql\Ddl to Mago compliance #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mundy merged 4 commits into from
Oct 12, 2026
Merged

Bring Sql\Ddl to Mago compliance #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a0f308
Return TableIdentifier tables from DDL raw state and type the processors
simon-mundy Oct 11, 2026
09426ce
Tag the Ddl component @api and clear it from the baselines
simon-mundy Oct 11, 2026
2dad529
Merge branch 'qa/mago-sql-predicate' into qa/mago-sql-ddl
simon-mundy Oct 12, 2026
8f93efe
Merge branch '0.6.x' into qa/mago-sql-ddl
simon-mundy Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
306 changes: 0 additions & 306 deletions analyzer-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,330 +1908,24 @@ code = "possibly-undefined-string-array-index"
message = "Possibly undefined array key `string('combine')` accessed on `array<string, array<string, list<array<int|string, string>|null>>|string>`."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\AlterTable` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "imprecise-type"
message = "Type `array` in return type of `getRawState` is imprecise, equivalent to `array<array-key, mixed>`."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "invalid-return-statement"
message = '''Invalid return type for function `PhpDb\Sql\Ddl\AlterTable::getRawState`: expected `array<array-key, mixed>|string`, but found `PhpDb\Sql\TableIdentifier|array<string, PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|string>|array{'addColumns': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|list<PhpDb\Sql\Ddl\Column\ColumnInterface>|string, 'addConstraints': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|list<PhpDb\Sql\Ddl\Constraint\ConstraintInterface>|string, 'changeColumns': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|array<string, PhpDb\Sql\Ddl\Column\ColumnInterface>|bool|int|string, 'dropColumns': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|list<string>|string, 'dropConstraints': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|list<string>|string, 'dropIndexes': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|bool|int|list<string>|string, 'table': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|PhpDb\Sql\TableIdentifier|bool|int|string, 'tableOptions': PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Literal|array<string, PhpDb\Sql\Literal|bool|int|string>|bool|int|string}|list<PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Ddl\Constraint\ConstraintInterface|string>|string`.'''
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "invalid-return-statement"
message = 'Invalid return type for function `PhpDb\Sql\Ddl\AlterTable::processTable`: expected `array<array-key, string>`, but found `list{array<array-key, mixed>|null|string}`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "possible-method-access-on-null"
message = "Attempting to call a method on `null`."
count = 5

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "possibly-null-argument"
message = 'Argument #2 of method `PhpDb\Sql\AbstractSql::processExpression` is possibly `null`, but parameter type `PhpDb\Adapter\Platform\PlatformInterface` does not accept it.'
count = 3

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "possibly-null-argument"
message = 'Argument #2 of method `PhpDb\Sql\AbstractSql::resolveTable` is possibly `null`, but parameter type `PhpDb\Adapter\Platform\PlatformInterface` does not accept it.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractLengthColumn.php"
code = "missing-api-or-internal"
message = 'Abstract class `PhpDb\Sql\Ddl\Column\AbstractLengthColumn` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractPrecisionColumn.php"
code = "missing-api-or-internal"
message = 'Abstract class `PhpDb\Sql\Ddl\Column\AbstractPrecisionColumn` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractTimestampColumn.php"
code = "missing-api-or-internal"
message = 'Abstract class `PhpDb\Sql\Ddl\Column\AbstractTimestampColumn` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/BigInteger.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\BigInteger` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Binary.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Binary` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Blob.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Blob` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Boolean.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Boolean` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Char.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Char` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Column.php"
code = "mixed-argument"
message = 'Invalid argument type for argument #1 of `PhpDb\Sql\Ddl\Column\Column::setDefault`: expected `PhpDb\Sql\Argument\Literal|PhpDb\Sql\Argument\Value|null|scalar`, but found `mixed`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Column.php"
code = "uninitialized-property"
message = 'Property `$default` is not initialized in the constructor of class `PhpDb\Sql\Ddl\Column\Column`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/ColumnInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Sql\Ddl\Column\ColumnInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Date.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Date` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Datetime.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Datetime` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Decimal.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Decimal` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Double.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Double` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Floating.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Floating` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Json.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Json` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/SmallInteger.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\SmallInteger` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Text.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Text` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Time.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Time` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Timestamp.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Timestamp` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Varbinary.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Varbinary` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/Varchar.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Column\Varchar` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/AbstractConstraint.php"
code = "missing-api-or-internal"
message = 'Abstract class `PhpDb\Sql\Ddl\Constraint\AbstractConstraint` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/Check.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Constraint\Check` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ConstraintInterface.php"
code = "missing-api-or-internal"
message = 'Interface `PhpDb\Sql\Ddl\Constraint\ConstraintInterface` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Constraint\ForeignKey` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "possibly-undefined-int-array-index"
message = "Possibly undefined array key `int(0)` accessed on `array<array-key, string>`."
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "possibly-undefined-int-array-index"
message = "Possibly undefined array key `int(1)` accessed on `array<array-key, string>`."
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/PrimaryKey.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Constraint\PrimaryKey` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/UniqueKey.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Constraint\UniqueKey` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\CreateTable` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "invalid-operand"
message = "Left operand in `&&` operation is an `array`."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "invalid-operand"
message = "Right operand in `&&` operation is an `array`."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "invalid-return-statement"
message = '''Invalid return type for function `PhpDb\Sql\Ddl\CreateTable::getRawState`: expected `array<array-key, PhpDb\Sql\Ddl\Column\ColumnInterface|array<array-key, PhpDb\Sql\Ddl\Column\ColumnInterface|string>|string>|string`, but found `PhpDb\Sql\TableIdentifier|array<string, PhpDb\Sql\Literal|bool|int|string>|array{'columns': PhpDb\Sql\Literal|bool|int|list<PhpDb\Sql\Ddl\Column\ColumnInterface>|string, 'constraints': PhpDb\Sql\Literal|bool|int|list<PhpDb\Sql\Ddl\Constraint\ConstraintInterface>|string, 'table': PhpDb\Sql\Literal|PhpDb\Sql\TableIdentifier|bool|int|string, 'tableOptions': PhpDb\Sql\Literal|array<string, PhpDb\Sql\Literal|bool|int|string>|bool|int|string}|list<PhpDb\Sql\Ddl\Column\ColumnInterface|PhpDb\Sql\Ddl\Constraint\ConstraintInterface>|string`.'''
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "invalid-return-statement"
message = 'Invalid return type for function `PhpDb\Sql\Ddl\CreateTable::processCombinedby`: expected `null|string`, but found `array<string, list<array<int|string, string>|null>>|null|string`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "invalid-return-statement"
message = '''Invalid return type for function `PhpDb\Sql\Ddl\CreateTable::processTable`: expected `array<array-key, string>`, but found `list{string('')|string('TEMPORARY '), string('')|string('IF NOT EXISTS '), array<array-key, mixed>|null|string}`.'''
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "possible-method-access-on-null"
message = "Attempting to call a method on `null`."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "possibly-null-argument"
message = 'Argument #2 of method `PhpDb\Sql\AbstractSql::processExpression` is possibly `null`, but parameter type `PhpDb\Adapter\Platform\PlatformInterface` does not accept it.'
count = 2

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "possibly-null-argument"
message = 'Argument #2 of method `PhpDb\Sql\AbstractSql::resolveTable` is possibly `null`, but parameter type `PhpDb\Adapter\Platform\PlatformInterface` does not accept it.'
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "possibly-undefined-string-array-index"
message = "Possibly undefined array key `string('combinedBy')` accessed on `array<string, array<string, list<array<int|string, string>|null>>|string>`."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "unused-parameter"
message = "Parameter `$adapterPlatform` is never used."
count = 2

[[issues]]
file = "src/Sql/Ddl/DropTable.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\DropTable` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Ddl/DropTable.php"
code = "invalid-return-statement"
message = '''Invalid return type for function `PhpDb\Sql\Ddl\DropTable::processTable`: expected `array<array-key, string>`, but found `list{string('')|string('IF EXISTS '), array<array-key, mixed>|null|string}`.'''
count = 1

[[issues]]
file = "src/Sql/Ddl/DropTable.php"
code = "possibly-null-argument"
message = 'Argument #2 of method `PhpDb\Sql\AbstractSql::resolveTable` is possibly `null`, but parameter type `PhpDb\Adapter\Platform\PlatformInterface` does not accept it.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Index/AbstractIndex.php"
code = "missing-api-or-internal"
message = 'Abstract class `PhpDb\Sql\Ddl\Index\AbstractIndex` is missing an `@api` or `@internal` annotation.'
count = 1

[[issues]]
file = "src/Sql/Ddl/Index/Index.php"
code = "class-must-be-final"
message = 'Class `PhpDb\Sql\Ddl\Index\Index` should be declared `final`.'
count = 1

[[issues]]
file = "src/Sql/Delete.php"
code = "class-must-be-final"
Expand Down
36 changes: 0 additions & 36 deletions lint-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,42 +378,6 @@ code = "no-array-accumulation-in-loop"
message = "Array spread in reassignment inside a loop causes O(n²) array copying."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "kan-defect"
message = "Class has a high kan defect score."
count = 1

[[issues]]
file = "src/Sql/Ddl/AlterTable.php"
code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractPrecisionColumn.php"
code = "excessive-parameter-list"
message = "Parameter list is too long."
count = 1

[[issues]]
file = "src/Sql/Ddl/Column/AbstractPrecisionColumn.php"
code = "halstead"
message = "Method has a high halstead difficulty"
count = 1

[[issues]]
file = "src/Sql/Ddl/Constraint/ForeignKey.php"
code = "excessive-parameter-list"
message = "Parameter list is too long."
count = 1

[[issues]]
file = "src/Sql/Ddl/CreateTable.php"
code = "too-many-methods"
message = "Class has too many methods."
count = 1

[[issues]]
file = "src/Sql/Insert.php"
code = "cyclomatic-complexity"
Expand Down
Loading
Loading