refactor: use shared PanelIcon enum values for built-in panel SVG keys. - #41
Conversation
…ms while preserving diagnostics, labels, and configurable names.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used🪛 PHPMD (2.15.0)tests/Panel/PanelIconTest.php[error] 40-40: Avoid using static access to class '\PHPForge\Debug\Panel\PanelIcon' in method 'testIconKeysPreserveExistingSvgResources'. (undefined) (StaticAccess) [error] 44-44: Avoid using static access to class '\PHPForge\Debug\Panel\PanelIcon' in method 'testIconKeysPreserveExistingSvgResources'. (undefined) (StaticAccess) [error] 52-52: Avoid using static access to class '\PHPForge\Debug\Helper\Icon' in method 'testIconKeysPreserveExistingSvgResources'. (undefined) (StaticAccess) 🔇 Additional comments (3)
📝 SummarySummary by CodeRabbit
WalkthroughThe change adds a string-backed ChangesShared Panel Icon Contract
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds shared built-in panel icon keys and validates that each key resolves to a bundled SVG. No current merge-readiness risk remains. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 99.95% 99.95%
Complexity 2177 2177
=========================================
Files 163 163
Lines 8677 8677
=========================================
Hits 8673 8673
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull Request