Skip to content

Iterate in getBooleanExpressionDepth() #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 2 commits into from
Jul 23, 2026
+8 −7
Merged

Iterate in getBooleanExpressionDepth() #6091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90b4d3e
Iterate in getBooleanExpressionDepth()
staabm Jul 23, 2026
bf4b91f
Update BooleanAndHandler.php
staabm Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Analyser/ExprHandler/BooleanAndHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,17 +162,18 @@ public function specifyTypes(TypeSpecifier $typeSpecifier, Scope $scope, Expr $e
return $types;
}

public static function getBooleanExpressionDepth(Expr $expr, int $depth = 0): int
public static function getBooleanExpressionDepth(Expr $expr): int
{
$depth = 0;
while (
$expr instanceof BooleanOr
|| $expr instanceof LogicalOr
|| $expr instanceof BooleanAnd
|| $expr instanceof LogicalAnd
$expr instanceof BooleanOr ||
$expr instanceof LogicalOr ||
$expr instanceof BooleanAnd ||
$expr instanceof LogicalAnd
) {
return self::getBooleanExpressionDepth($expr->left, $depth + 1);
$depth++;
$expr = $expr->left;
}

return $depth;
}

Expand Down
Loading