Repository navigation
Link the shell with the engine version, past CDN caches (0.6.2) - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the 0.6.1 upgrade, notes.pierg.dev kept serving the old shell: Cloudflare caches
.jsand.cssby default, and the server's log shows readers' requests for the page but none for/shell/folio.js. The origin was serving the new file withCache-Control: no-cache.What
render.rewritelinks the shell as/shell/folio.js?v=<version>and/shell/folio.css?v=<version>(under--basetoo), so each folio version is a new address for any cache. The server and the exported site ignore the query. Spec: model §14. Version 0.6.2.Gate
python -m pytest -q: 377 passed, 2 skipped.cd docs && folio check: 0 errors.