Repository navigation
A home map has Current storylines (1.14.0) - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every lab that names active storylines shows them in the same place. One of the library's home maps (
home.mapsin folio.yaml) has a section<h2 id="current-storylines">Current storylines</h2>, and its rows are the active storyline pages and nothing else.lab check(instorylines.py) refuses each of these:rowslist, up to the next h2 or h3 or the end ofmain.folio map add --sectionandfolio map move. The CHANGELOG has a 1.14.0 entry with an upgrade line, and the version is 1.14.0.tests/test_storylines.py, the fixture writes a charter and a home map. A new test covers each refusal, plus the forms a link can take that are not rows.Gate:
python -m pytest -qgives 83 passed and 10 skipped. The 2 dead-run tests fail in cloud containers, as they do on main.