Repository navigation
A later results review can supersede an earlier one, by name (1.15.0) - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A reviewed row that has to be read another way, to the same result, could not be fixed. In proofs-lab, G4.Q2.15's
shell-deniedrow read the run by a fixed path, whichlab checkrefuses ("command never reads $RUN"). The row was rewritten to read$RUN, with the same value 0, and a second review passed it. The history check still said "a row that a review had passed in 1274c4d8 is gone or changed", and putting the old row back brought back the$RUNfailure. The gate on proofs-lab's main has been red since.What changes
lab review <experiment> results pass "<why>" --supersedes <of>names the earlier passing results review by itsof(8 to 16 hex digits). It ends the note with "Supersedes the results review of .". Once that review is committed together with the rows it read, the history check holds those rows instead of the ones the earlier review read; until then it supersedes nothing.lab reviewrefuses--supersedeson a plan review or a failing review, for anofthat no earlier passing results review has, and when the earlier review read the rows as they are now; it refuses a note that ends with the sentence typed by hand.lab checkrefuses a note that names no earlier passing results review of other rows.Tests
Three new tests in
tests/test_held.py: the refusals and the supersession with the new rows held in their turn; a forged marker; and a superseding review committed without its rows, which frees nothing. The full suite passes locally except two tests about stopping a dead run's processes, which fail the same way on main in that container.