Repository navigation
ci(typecheck): check JSDoc types with tsc in CI (part 1) - #4272
Conversation
Add tsconfig.check.json (explicit stack folders), pin typescript 5.9.3, add npm run typecheck and a CI step on the unit job after lint. Fix the JSDoc errors tsc reports; drop the dead helmet hsts force and aggregate noCursorTimeout options. One @ts-expect-error for the Stripe pinned apiVersion (documented by stripe-node). Closes #4269
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4272 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 175 175
Lines 6218 6220 +2
Branches 2020 2018 -2
=======================================
+ Hits 5885 5887 +2
Misses 270 270
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
What / Why
TypeScript now checks the JSDoc types we already write, in CI (part 1 of 2).
No behaviour change.
Tech detail
tsconfig.check.json:allowJs+checkJs+noEmit, loose settings, explicit stack folder include (lib,config,server.js, modulescore/home/audit/public/tasks); tests excluded.typescriptpinned to 5.9.3, newnpm run typecheck, CI step added after lint on the unit job.readFileSyncwithutf8,winston.createLoggerwithoutnew, unused argument dropped in theinitModulesServerPoliciescall.force(not in helmet 8); aggregatenoCursorTimeout(only read byfindin mongodb 7).@ts-expect-error(Stripe pinnedapiVersion, as stripe-node docs advise).Downstream note
Projects inherit the config and the CI step. The include list names stack folders only, so project modules are not checked unless a project adds them.
Review
Pre-push review OK with nits, security pass no HIGH/MEDIUM.
Closes #4269