Repository navigation
Generate the cask's quarantine hook as postflight_steps - #1
Merged
Merged
Conversation
Homebrew 7.0.12 warns that the cask's Ruby `postflight` block is
deprecated. GoReleaser 2.19 (which the release workflow's `~> v2`
already picks up) adds `install_steps`, which renders the declarative
`postflight_steps` stanza; `{{ .StagedPath }}` becomes Homebrew's
install-time `{{staged_path}}` token.
Also add the trailing slash `brew style` wants on the homepage.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew 7.0.12 warns on every update that the pingstack cask's
postflightblock is deprecated. pingstack-io/homebrew-tap#1 fixes the cask by hand, but GoReleaser generates that file, so the next release would bring the old block back. This changes the source.hooks.post.installbecomesinstall_steps(new in GoReleaser 2.19, which the workflows'version: "~> v2"already pick up). It renderspostflight_stepswith arunstep on/usr/bin/xattr.{{ .StagedPath }}renders as Homebrew's install-time{{staged_path}}token.brew stylewants.Checked with GoReleaser 2.19.0:
goreleaser checkpasses, and a snapshot build generates a cask matching the tap PR, apart from version, URLs and checksums, with one exception. 2.19.0 still writes# No zap stanza requiredinstead ofzap :not_required. GoReleaser's fix for that (goreleaser/goreleaser#7253) is merged but not released yet, so a release before then will put the comment back. That only affectsbrew style; users see no warning.🤖 Generated with Claude Code