Skip to content

Add the public API for send side BWE - #55

Open
mengelbart wants to merge 1 commit into
mainfrom
feat/send-side-bwe-controller
Open

Add the public API for send side BWE#55
mengelbart wants to merge 1 commit into
mainfrom
feat/send-side-bwe-controller

Conversation

@mengelbart

Copy link
Copy Markdown
Contributor

The current API requires users to call OnAck and OnLoss for each packet in a report, then call OnFeedback. An alternative would be to have only a single method accepting a report data structure so the controller can read (and sort) it internally. The downside would be that we need a common data structure for this, which would force users to build it manually and require additional loops (the client loops through his report to build the structure, and we loop through it to consume it). That may be fine for use within pion, but it makes it harder to use the algorithm elsewhere. Any opinions?

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.81%. Comparing base (3d39820) to head (4d3b0e9).

Files with missing lines Patch % Lines
gcc/send_side_bwe.go 88.88% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   99.09%   97.81%   -1.28%     
==========================================
  Files           9       10       +1     
  Lines         441      504      +63     
==========================================
+ Hits          437      493      +56     
- Misses          2        6       +4     
- Partials        2        5       +3     
Flag Coverage Δ
go 97.81% <88.88%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart
mengelbart force-pushed the feat/send-side-bwe-controller branch from 2d206d1 to 39c75bf Compare September 7, 2026 11:29
@mengelbart
mengelbart marked this pull request as ready for review September 7, 2026 11:30
@mengelbart
mengelbart force-pushed the feat/send-side-bwe-controller branch from 39c75bf to 14758d1 Compare September 7, 2026 19:20
@mengelbart
mengelbart force-pushed the feat/send-side-bwe-controller branch from 14758d1 to 4d3b0e9 Compare September 10, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant