Add the public API for send side BWE - #55
Open
mengelbart wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 99.09% 97.81% -1.28%
==========================================
Files 9 10 +1
Lines 441 504 +63
==========================================
+ Hits 437 493 +56
- Misses 2 6 +4
- Partials 2 5 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
feat/send-side-bwe-controller
branch
from
September 7, 2026 11:29
2d206d1 to
39c75bf
Compare
mengelbart
marked this pull request as ready for review
September 7, 2026 11:30
mengelbart
force-pushed
the
feat/send-side-bwe-controller
branch
from
September 7, 2026 19:20
39c75bf to
14758d1
Compare
mengelbart
force-pushed
the
feat/send-side-bwe-controller
branch
from
September 10, 2026 13:27
14758d1 to
4d3b0e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current API requires users to call
OnAckandOnLossfor each packet in a report, then callOnFeedback. An alternative would be to have only a single method accepting a report data structure so the controller can read (and sort) it internally. The downside would be that we need a common data structure for this, which would force users to build it manually and require additional loops (the client loops through his report to build the structure, and we loop through it to consume it). That may be fine for use within pion, but it makes it harder to use the algorithm elsewhere. Any opinions?