Skip to content

Remove fallback because peer will only send TWCC #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mengelbart wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −6
Open

Remove fallback because peer will only send TWCC #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pkg/rtpfb/interceptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ type Interceptor struct {
}

func (i *Interceptor) bindTWCCStream(twccHdrExtID uint8, writer interceptor.RTPWriter) interceptor.RTPWriter {
loggedMissingExt := false

return interceptor.RTPWriterFunc(func(
header *rtp.Header,
payload []byte,
Expand All @@ -119,12 +121,14 @@ func (i *Interceptor) bindTWCCStream(twccHdrExtID uint8, writer interceptor.RTPW

var twccHdrExt rtp.TransportCCExtension
if err := twccHdrExt.Unmarshal(header.GetExtension(twccHdrExtID)); err != nil {
i.log.Warnf(
"CCFB configured for TWCC, but failed to get TWCC header extension from outgoing packet."+
"Falling back to saving history for CCFB feedback reports. err: %v",
err,
)
i.history.addOutgoing(header.SSRC, header.SequenceNumber, false, 0, header.MarshalSize()+len(payload), ts)
if !loggedMissingExt {
i.log.Warnf(
"CCFB configured for TWCC, but failed to get TWCC header extension from outgoing packet."+
"Packets without the extension cannot be tracked and will not appear in feedback reports. err: %v",
err,
)
loggedMissingExt = true
}

return writer.Write(header, payload, attributes)
}
Expand Down
Loading