Skip to content

Add one MTU headroom to pacing burst - #457

Merged
mengelbart merged 1 commit into
mainfrom
fix/pacing-burst
Sep 8, 2026
Merged

Add one MTU headroom to pacing burst#457
mengelbart merged 1 commit into
mainfrom
fix/pacing-burst

Conversation

@mengelbart

@mengelbart mengelbart commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This adds one MTU of headroom to the pacing burst. Without it, the burst will be clamped every interval. That is a problem when the pacer has left over tokens but not enough for a complete packet. The leftover tokens should be usable in the next interval, but they're clamped by the max burst, so we drop them instead of using them on the next packet.

@mengelbart
mengelbart requested a review from JoTurk September 7, 2026 18:31
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.52%. Comparing base (13100ce) to head (0f12f31).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   81.44%   81.52%   +0.08%     
==========================================
  Files          88       88              
  Lines        4656     4656              
==========================================
+ Hits         3792     3796       +4     
+ Misses        686      684       -2     
+ Partials      178      176       -2     
Flag Coverage Δ
go 81.52% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart
mengelbart merged commit a0af02f into main Sep 8, 2026
19 checks passed
@mengelbart
mengelbart deleted the fix/pacing-burst branch September 8, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants