Add a warning for strings containing ] and } - #5
Open
PhoenixBound wants to merge 1 commit into
Open
Conversation
It's rare to need to type these characters. More often than not, as
happened this morning, people write things in the CCScriptWriter style
of "shove all the commands into a string" and occasionally have copy-
paste mistakes like this:
"{goto_if_true(0xc5e1d6)}]{load_registers}"
^~this right square bracket
Not sure how many beginners' scripts have errors like this, or scripts
on the wiki for that matter, so... yet another warning it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's rare to need to type these characters. More often than not, as happened this morning, people write things in the CCScriptWriter style of "shove all the commands into a string" and occasionally have copy-paste mistakes like this:
(In this case, a
[1B 03 {e(data_xx.l_0xc5e1d6)}]only had its front half corrected to use a stdext command, and the]from the control code was left in by accident.)Not sure how many beginners' scripts have errors like this, or scripts on the wiki for that matter, so... yet another warning it is. I'm not attached to the specific method used for reporting the warning, I just wanted more freedom to write a natural error message