fix: remove stale npm metadata for private packages - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an indexed package becomes private, skipping npm requests leaves its previous PACKUMENT and PACKAGE_MANIFEST records in the database. Subsequent site builds still export the old packument in projects.json.
Delete both npm records in the same LevelDB batch that saves the private PACKAGE_JSON. Add regression coverage using a temporary LevelDB database for public-to-private transitions, repeated indexing, new private packages, preservation of other projects, exported project data, and restoration of npm metadata when a package becomes public again.
Validation: