`pio test` compiles with and without `UNIT_TEST` defined

[Shoxx98]

I am having an issue where I build a file in a test environment and am testing for the presence of the macro UNIT_TEST in a library and have a different size of global variables depending on if the macro is defined or not.
If I check for the define using a codesnippet like this, I get both manually-placed warnings during compilation using pio test, ARENA_SIZE is 200 in the end and the linker tells me that SRAM overflows because of it:

#ifdef UNIT_TEST
#warning "unit test active"
#define ARENA_SIZE 100
#else
#warning "unit test not active"
#define ARENA_SIZE 200
#endif /* ifdef UNIT_TEST */
uint8_t arena[ARENA_SIZE];

I am using a fork of platformio-core that has an additional target __test to generate a compiledb for the test-dir (#5480). I don't know whether this is an issue of platformio-core as-is, or if it is an issue with the branch, so I am creating the issue here and am mentioning the PR.

I expect the ARENA_SIZE to be 100 while compiling and linking.

[Shoxx98]

the relevant part of the env is defined like so in platformio.ini:

[msp430g2553]
board = lpmsp430g2553
board_build.mcu = msp430g2553
; you probably have to change the port quite a lot
test_port = /dev/somedevice
test_speed = 19200

[env:unity_tests_arena]
extends = msp430g2553
build_flags =  -std=gnu99 -g -Wall
lib_deps = throwtheswitch/Unity@^2.6.1
test_filter = 
    test_something

I envoke pio test -e unity_tests_arena whenever I want to test the code using that env

[ivankravets]

Please share a simple PIO project as a ZIP/Github repository so we can reproduce the issue. Thanks.

[jagadeepmamidi]

I checked the current PlatformIO Core implementation and noticed that UNIT_TEST is deprecated, while PIO_UNIT_TESTING is propagated to project sources and dependent libraries during test builds.

Could you check whether replacing UNIT_TEST with PIO_UNIT_TESTING resolves the issue? If it still occurs, a minimal reproduction repository would help confirm whether this is an upstream PlatformIO Core issue or is related to the changes in #5480.

[Shoxx98]

I checked the current PlatformIO Core implementation and noticed that UNIT_TEST is deprecated, while PIO_UNIT_TESTING is propagated to project sources and dependent libraries during test builds.

Could you check whether replacing UNIT_TEST with PIO_UNIT_TESTING resolves the issue? If it still occurs, a minimal reproduction repository would help confirm whether this is an upstream PlatformIO Core issue or is related to the changes in #5480.

will do on monday

[Shoxx98]

simple PIO project

test_pio.zip

when I enter pio test, this is part of the output:

In file included from test/test_foo/test_foo.c:10:0:
lib/foo/include/foo.h:19:2: warning: #warning "unit test defined" [-Wcpp]
 #warning "unit test defined"
  ^~~~~~~
In file included from lib/foo/src/foo.c:10:0:
lib/foo/include/foo.h:21:2: warning: #warning "unit test undefined" [-Wcpp]
 #warning "unit test undefined"
  ^~~~~~~

I expect only the first warning to appear

this foo.h gives an error instead of the linker for my project:

foo.h.zip

[Shoxx98]

Could you check whether replacing UNIT_TEST with PIO_UNIT_TESTING resolves the issue?

foo.h.zip

It does not.

[Shoxx98]

I tested the same procedure in an archlinux docker environment where I installed the main version of platformio-core using pacman, mounted the project dir to /mnt/test_pio of the docker image and ran pio test. The same warnings were generated. Here is a logfile of the tty:

pio_test_log_arch_container.txt

the foo.h with PIO_UNIT_TESTING was used

[jagadeepmamidi]

Thanks for sharing, @Shoxx98. In the attached Docker log, both lib/foo/src/foo.c and test/test_foo/test_foo.c show “unit test defined”. The failure shown is due to a missing upload_port. Could you confirm whether this is the intended log? It looks like the macro issue isn’t reproduced in this run.

[Shoxx98]

In the attached Docker log, both lib/foo/src/foo.c and test/test_foo/test_foo.c show “unit test defined”.

yeah I also just noticed that. let me look for what went on there and if it's fixable for me. I wasn't sure if this gets read right now so I didn't correct myself rightaway

[Shoxx98]

okay my bad, PIO_UNIT_TESTING fixes this for me. Thanks!