Skip to content

Fixed -U undefine flag being dropped when separated from its name b… - #5518

Closed
Isl-n wants to merge 1 commit into
platformio:developfrom
Isl-n:fix/5237-undefine-with-space
Closed

Isl-n wants to merge 1 commit into
platformio:developfrom
Isl-n:fix/5237-undefine-with-space

Conversation

@Isl-n

@Isl-n Isl-n commented Sep 18, 2026

Copy link
Copy Markdown

…y a space // Resolve #5237

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ivankravets

Copy link
Copy Markdown
Member

How did you find PlatformIO?

@ivankravets

Copy link
Copy Markdown
Member

Thanks for the PR. Resolved in #5237

@Isl-n

Isl-n commented Sep 20, 2026

Copy link
Copy Markdown
Author

I found PlatformIO while working on an ESP32 project at a course and really liked the ecosystem. Thanks for building it—I'll keep an eye out for other open issues to contribute to!

@Isl-n
Isl-n deleted the fix/5237-undefine-with-space branch September 20, 2026 10:34
@ivankravets

Copy link
Copy Markdown
Member

I like the solution in this PR. Did you use any AI model?

@Isl-n

Isl-n commented Sep 20, 2026

Copy link
Copy Markdown
Author

Yes, Here is my exact workflow:
1- Used AI code review and search tools to scan the repository for open bugs/features to work on.
2- Selected this issue and worked through the fix using Claude Sonnet.
3- Ran pytest locally to verify the solution and make sure all tests passed green.
4- Submitted the PR once everything was fully tested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefines in build_flags don't work if there's a space after -U

3 participants