Web manifest enhancement - #11
Open
cehan-Chloe wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
+ Coverage 21.91% 33.61% +11.70%
===========================================
Files 26 27 +1
Lines 1807 1889 +82
Branches 89 140 +51
===========================================
+ Hits 396 635 +239
+ Misses 1410 1252 -158
- Partials 1 2 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cehan-Chloe
marked this pull request as ready for review
August 31, 2026 13:59
KetanReddy
reviewed
Sep 1, 2026
KetanReddy
reviewed
Sep 1, 2026
KetanReddy
reviewed
Sep 3, 2026
| fs.readFileSync(path.join(packageDir, "package.json"), "utf-8"), | ||
| ); | ||
| } catch { | ||
| return undefined; |
Member
There was a problem hiding this comment.
Do we want to log a warning/error here?
KetanReddy
reviewed
Sep 3, 2026
| * Elsewhere the package manager keeps `package.json` current and it is read directly. | ||
| */ | ||
|
|
||
| export type WarnFn = (message: string) => void; |
Member
There was a problem hiding this comment.
Do we need to redefine this or can we use the type from oclif?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump xlr version to include change for interface Manifest enhancement to provide package information xlr#13 https://github.com/player-ui/xlr/releases/tag/1.1.0-next.0
read package name and version
this is combined with Pass the package name and stamped version to xlr compile rules_player#120
test result using player's reference-assets
Change Type (required)
Indicate the type of change your pull request is:
patchminormajor