Support Behat 4 - #3
Merged
Merged
Conversation
The fixture configuration moves to behat.php, the only form Behat 4 accepts and one that Behat 3 reads as well. The Symfony Config, DependencyInjection and EventDispatcher components the extension calls directly are declared instead of relied on transitively, with Symfony 8 allowed for Behat 4. CI runs Behat 4.0.0-alpha1 and a lowest-dependencies job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code runs unchanged on Behat 4.0.0-alpha1. This PR makes CI prove it and
declares what the extension actually depends on.
tests/Fixtures/behat.phpreplacesbehat.yml: Behat 4 drops YAMLconfiguration, and the PHP form works on 3.x as well.
symfony/config,symfony/dependency-injectionandsymfony/event-dispatcherare declared (^5.4 || ^6.4 || ^7.0 || ^8.0)instead of relied on transitively.
4.0.0-alpha1.
The Behat constraint stays
^3.23until 4.0.0 stable ships.