Name failure screenshots after the failing test - #169
Open
jacekzlotnicki wants to merge 2 commits into
Open
Conversation
PHPUnit 10 renamed getName() to name(), so the method_exists() check in tearDownPlaywright() always fell through to the 'test' default. With more than one failing test in a run, every screenshot overwrote the previous one and the evidence was gone by the time the run finished. resolveTestName() asks name() first and falls back to getName(), so the trait keeps working on PHPUnit 9 as well. The name ends up in a file name and a data set turns it into something like `testFoo with data set "a/b"`, so it is sanitized before use.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The loop skipping a missing accessor and the final default were the two lines Codecov reported as uncovered.
jacekzlotnicki
force-pushed
the
fix/failure-screenshot-name
branch
from
September 10, 2026 19:13
9fe1f39 to
b2695c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 10 renamed getName() to name(), so the method_exists() check in tearDownPlaywright() always fell through to the 'test' default. With more than one failing test in a run, every screenshot overwrote the previous one and the evidence was gone by the time the run finished.
resolveTestName() asks name() first and falls back to getName(), so the trait keeps working on PHPUnit 9 as well. The name ends up in a file name and a data set turns it into something like
testFoo with data set "a/b", so it is sanitized before use.