fix: export PreviewBanner.astro from package exports map - #5
Merged
Merged
Conversation
The PreviewBanner component shipped in src/ but was never added to the exports map, so deep imports of @pliosoft/sites-sdk/components/PreviewBanner.astro fail to resolve. This breaks the build of every customer site generated from the current sites-template (which imports it in Base.astro). Bump to 0.2.2 for a patch release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@pliosoft/sites-sdk@0.2.1shipped the PreviewBanner component insrc/(added in #4) but never added it to the packageexportsmap. Deep imports of@pliosoft/sites-sdk/components/PreviewBanner.astrotherefore fail to resolve.The current
sites-templateimports PreviewBanner insrc/layouts/Base.astro, so every customer site generated from the template fails to build in the sites-app deploy pipeline:First observed on
beaver-hills-press(new customer, site 404s because the deploy never succeeds).Fix
./components/PreviewBanner.astrotoexports(the build script already copies it intodist/)After merge, tag
v0.2.2to trigger the npm publish workflow, then rebuild affected customer sites.🤖 Generated with Claude Code