Skip to content

Fix: decode group search filter as array instead of object #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rom1-B wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fix: decode group search filter as array instead of object #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Fixed

- Decode dynamic group search filter as an array instead of an object

## [1.1.3] - 2026-05-05

### Fixed
Expand Down
3 changes: 2 additions & 1 deletion inc/computergroupdynamic.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

use function Safe\json_decode;
use function Safe\unserialize;
use function Safe\json_encode;
use function Safe\ob_start;
use function Safe\ob_get_clean;
Expand Down Expand Up @@ -182,7 +183,7 @@ private function countDynamicItems()
public function isDynamicSearchMatchComputer(Computer $computer)
{
// add new criteria to force computer ID
$search = json_decode((string) $this->fields['search']);
$search = json_decode((string) $this->fields['search'], true, 512, JSON_THROW_ON_ERROR);

$search['criteria'][] = [
'link' => 'AND',
Expand Down